pdbdump: Fix crash bug.

[ruiu]

Summary

pdbdump calls DbiStreamBuilder::commit through PDBFileBuilder::commit
without calling DbiStreamBuilder::finalize. Because finalize initializes
Header member, Header remained nullptr which caused a crash bug.

[majnemer]

test/DebugInfo/PDB/pdbdump-readwrite.test

5

Why remove this run line?

[ruiu]

• Updated the correct patch.

[ruiu]

I had a temporary patch between this one and origin/head, and that appeared as deleted lines. Updated the right patch.

include/llvm/DebugInfo/PDB/Raw/DbiStreamBuilder.h

public:
   uint32_t calculateSerializedLength() const;
 
   Error addModuleInfo(StringRef ObjFile, StringRef Module);
   Error addModuleSourceFile(StringRef Module, StringRef File);
 
   Expected<std::unique_ptr<DbiStream>> build(PDBFile &File,
                                              const msf::WritableStream &Buffer);
   Error commit(const msf::MSFLayout &Layout,
-               const msf::WritableStream &Buffer) const;
+               const msf::WritableStream &Buffer);
 
 private:
   Error finalize();
   uint32_t calculateModiSubstreamSize() const;
   uint32_t calculateFileInfoSubstreamSize() const;
   uint32_t calculateNamesBufferSize() const;
 
   Error generateModiSubstream();

lib/DebugInfo/PDB/Raw/DbiStreamBuilder.cpp

DbiStreamBuilder::build(PDBFile &File, const msf::WritableStream &Buffer) {
   if (auto EC = Dbi->initializeModInfoArray())
     return std::move(EC);
   if (auto EC = Dbi->initializeFileInfo())
     return std::move(EC);
   return std::move(Dbi);
 }
 
 Error DbiStreamBuilder::commit(const msf::MSFLayout &Layout,
-                               const msf::WritableStream &Buffer) const {
+                               const msf::WritableStream &Buffer) {
+  if (auto EC = finalize())
+    return EC;
+
   auto InfoS =
       WritableMappedBlockStream::createIndexedStream(Layout, Buffer, StreamDBI);
 
   StreamWriter Writer(*InfoS);
   if (auto EC = Writer.writeObject(*Header))
     return EC;
 
   if (auto EC = Writer.writeStreamRef(ModInfoBuffer))

test/DebugInfo/PDB/pdbdump-readwrite.test

+; RUN: llvm-pdbdump pdb2yaml -dbi-module-info -dbi-module-source-info \
+; RUN:   -dbi-stream -pdb-stream -stream-directory -stream-metadata \
+; RUN:   %p/Inputs/empty.pdb > %t.1
+; RUN: llvm-pdbdump yaml2pdb -pdb=%t.2 %t.1