This is an archive of the discontinued LLVM Phabricator instance.

pdbdump: Fix crash bug.
ClosedPublic

Authored by ruiu on Aug 3 2016, 4:24 PM.

Details

Summary

pdbdump calls DbiStreamBuilder::commit through PDBFileBuilder::commit
without calling DbiStreamBuilder::finalize. Because finalize initializes
Header member, Header remained nullptr which caused a crash bug.

Diff Detail

Repository
rL LLVM

Event Timeline

ruiu updated this revision to Diff 66731.Aug 3 2016, 4:24 PM
ruiu retitled this revision from to pdbdump: Fix crash bug..
ruiu updated this object.
ruiu added a reviewer: zturner.
ruiu added a subscriber: llvm-commits.
majnemer added inline comments.
test/DebugInfo/PDB/pdbdump-readwrite.test
5 ↗(On Diff #66731)

Why remove this run line?

ruiu updated this revision to Diff 66734.Aug 3 2016, 4:33 PM
  • Updated the correct patch.
ruiu added a comment.Aug 3 2016, 4:33 PM

I had a temporary patch between this one and origin/head, and that appeared as deleted lines. Updated the right patch.

zturner accepted this revision.Aug 3 2016, 4:47 PM
zturner edited edge metadata.
This revision is now accepted and ready to land.Aug 3 2016, 4:47 PM
This revision was automatically updated to reflect the committed changes.