Page MenuHomePhabricator

[mips] Add l.[sd] and s.[sd] instruction aliases
ClosedPublic

Authored by sdardis on Aug 3 2016, 6:49 AM.

Details

Diff Detail

Event Timeline

sdardis updated this revision to Diff 66660.Aug 3 2016, 6:49 AM
sdardis retitled this revision from to [mips] Add l.[sd] and l.[sd] instruction aliases.
sdardis updated this object.
sdardis added reviewers: dsanders, vkalintiris.
sdardis set the repository for this revision to rL LLVM.
sdardis added a subscriber: llvm-commits.

Small typo in title: you have l.[sd] twice

sdardis retitled this revision from [mips] Add l.[sd] and l.[sd] instruction aliases to [mips] Add l.[sd] and s.[sd] instruction aliases.Aug 3 2016, 6:56 AM

Fixed.

vkalintiris accepted this revision.Aug 17 2016, 5:38 AM
vkalintiris edited edge metadata.

LGTM with two small test fixes.

test/MC/Mips/mips32r6/valid.s
142–143

Currently, the check patterns expect the s.{s,d} aliases instead of the actual instructions.

test/MC/Mips/mips64r6/valid.s
199–200

Currently, the check patterns expect the s.{s,d} aliases instead of the actual instructions.

This revision is now accepted and ready to land.Aug 17 2016, 5:38 AM
sdardis closed this revision.Aug 17 2016, 7:54 AM
sdardis marked an inline comment as done.

Thanks, committed rL278930.