This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Fix broken interception unittest
ClosedPublic

Authored by etienneb on Aug 2 2016, 7:31 PM.

Details

Summary

This patch is fixing a broken unittest which make the win64 bot failing.

The bug was introduce here:

https://reviews.llvm.org/D23046

The interception code is not the same in 32-bit and in 64-bit.
The added unittest can only be patched on 32-bits.

Diff Detail

Event Timeline

etienneb updated this revision to Diff 66608.Aug 2 2016, 7:31 PM
etienneb retitled this revision from to [compiler-rt] Fix broken interception unittest.
etienneb updated this object.
etienneb added a reviewer: rnk.
etienneb added subscribers: chrisha, llvm-commits.
rnk accepted this revision.Aug 2 2016, 7:34 PM
rnk edited edge metadata.

Lgtm. Sorry, I thought the x64 interception tests were broken on win10 for unrelated reasons.

This revision is now accepted and ready to land.Aug 2 2016, 7:34 PM
etienneb closed this revision.Aug 2 2016, 7:52 PM