Page MenuHomePhabricator

[ADCE] Refactor anticipating new functionality (NFC)
ClosedPublic

Authored by david2050 on Aug 2 2016, 9:13 AM.

Details

Summary

This is the first refactoring before adding new functionality.
Add a class wrapper for the functions and container for
state associated with the transformation.

No functional change

Diff Detail

Event Timeline

david2050 updated this revision to Diff 66485.Aug 2 2016, 9:13 AM
david2050 retitled this revision from to [ADCE] Refactor anticipating new functionality (NFC).
david2050 updated this object.
david2050 updated this revision to Diff 66486.Aug 2 2016, 9:16 AM

Undo a clang-format include reordering

nadav edited edge metadata.Aug 2 2016, 12:19 PM

LGTM.

mehdi_amini added inline comments.Aug 2 2016, 12:27 PM
lib/Transforms/Scalar/ADCE.cpp
42

Can you document these fields?

david2050 updated this revision to Diff 66537.Aug 2 2016, 1:05 PM
david2050 edited edge metadata.

Comments for state variables

mehdi_amini edited edge metadata.Aug 2 2016, 1:06 PM

Thanks, LGTM for me as well.

david2050 marked an inline comment as done.Aug 2 2016, 8:56 PM

I have a process question.
Will we commit the incremental diffs? in which case would one of you "accept" this on.
Or do I continue to update this diff with more changes until we are code complete?

mehdi_amini accepted this revision.Aug 2 2016, 8:57 PM
mehdi_amini edited edge metadata.

Sorry I meant to mark it accepted, please commit.

This revision is now accepted and ready to land.Aug 2 2016, 8:57 PM
david2050 closed this revision.Aug 2 2016, 9:35 PM