This is an archive of the discontinued LLVM Phabricator instance.

PDB: Mark extended file pages as free by default.
ClosedPublic

Authored by ruiu on Aug 1 2016, 7:08 PM.

Reviewers

Commits

Summary

BitVector::extend initializes extended bits as true by default.
That is not desirable because new pages should be initially free.

ruiu retitled this revision from to PDB: Mark extended file pages as free by default..

ruiu updated this object.

ruiu added a reviewer: zturner.

ruiu added a subscriber: llvm-commits.

zturner edited edge metadata.

This revision is now accepted and ready to land.Aug 2 2016, 8:59 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

DebugInfo/

MSF/

2 lines

	Show First 20 Lines • Show All 47 Lines • ▼ Show 20 Lines
	Error MSFBuilder::setBlockMapAddr(uint32_t Addr) {			Error MSFBuilder::setBlockMapAddr(uint32_t Addr) {
	if (Addr == BlockMapAddr)			if (Addr == BlockMapAddr)
	return Error::success();			return Error::success();

	if (Addr >= FreeBlocks.size()) {			if (Addr >= FreeBlocks.size()) {
	if (!IsGrowable)			if (!IsGrowable)
	return make_error<MSFError>(msf_error_code::insufficient_buffer,			return make_error<MSFError>(msf_error_code::insufficient_buffer,
	"Cannot grow the number of blocks");			"Cannot grow the number of blocks");
	FreeBlocks.resize(Addr + 1);			FreeBlocks.resize(Addr + 1, true);
	}			}

	if (!isBlockFree(Addr))			if (!isBlockFree(Addr))
	return make_error<MSFError>(			return make_error<MSFError>(
	msf_error_code::block_in_use,			msf_error_code::block_in_use,
	"Requested block map address is already in use");			"Requested block map address is already in use");
	FreeBlocks[BlockMapAddr] = true;			FreeBlocks[BlockMapAddr] = true;
	FreeBlocks[Addr] = false;			FreeBlocks[Addr] = false;
	▲ Show 20 Lines • Show All 215 Lines • Show Last 20 Lines