This is an archive of the discontinued LLVM Phabricator instance.

pdbdump: Do not treat stream 0 pages as allocated pages.
ClosedPublic

Authored by ruiu on Aug 1 2016, 6:57 PM.

Details

Summary

I examined a few PDBs and all of them treated pages for stream 0
are unused, thus they were unmarked in their free page bitmap.
I think we should do the same thing for compatibility.

Diff Detail

Event Timeline

ruiu updated this revision to Diff 66421.Aug 1 2016, 6:57 PM
ruiu retitled this revision from to pdbdump: Do not treat stream 0 pages as allocated pages..
ruiu updated this object.
ruiu added a reviewer: zturner.
ruiu added a subscriber: llvm-commits.
zturner requested changes to this revision.Aug 2 2016, 9:02 AM
zturner edited edge metadata.
zturner added inline comments.
tools/llvm-pdbdump/LLVMOutputStyle.cpp
315

This isn't the correct check. S here is a block number, not a stream number (Feel free to rename this to B if you want). The outer loop should be written:

for (auto &SE : File.getStreamMap().drop_front(1))
This revision now requires changes to proceed.Aug 2 2016, 9:02 AM
ruiu updated this revision to Diff 66587.Aug 2 2016, 4:15 PM
ruiu edited edge metadata.
  • Updated as per Zach's comment.
zturner accepted this revision.Aug 2 2016, 4:28 PM
zturner edited edge metadata.
This revision is now accepted and ready to land.Aug 2 2016, 4:28 PM
This revision was automatically updated to reflect the committed changes.