Page MenuHomePhabricator

[InstrumentationRuntime] Refactor the API (Part 1/N) (NFCI)
ClosedPublic

Authored by vsk on Aug 1 2016, 6:00 PM.

Details

Summary

Adapters for instrumentation runtimes have to do two basic things:

  1. Load a runtime library.
  2. Install breakpoints in that library.

This logic is duplicated in the adapters for asan and tsan. Factor it
out and document bits of it to make it easier to add new adapters.

I tested this with check-lldb, and double-checked
testcases/functionalities/{a,t}san.

Diff Detail

Event Timeline

vsk updated this revision to Diff 66411.Aug 1 2016, 6:00 PM
vsk retitled this revision from to [InstrumentationRuntime] Refactor the API (Part 1/N) (NFCI).
vsk updated this object.
vsk added reviewers: kubamracek, k8stone.
vsk added subscribers: lldb-commits, friss.
kubamracek accepted this revision.Aug 11 2016, 8:03 AM
kubamracek edited edge metadata.

LGTM

This revision is now accepted and ready to land.Aug 11 2016, 8:03 AM
This revision was automatically updated to reflect the committed changes.