[ELF] - Fix: do not ignore relocations addends when using lld -r

[grimar]

Summary

Previously addend was ignored. This is PR28779.
Patch fixes the issue.

[ruiu]

LGTM. Thank you for doing this.

lld/trunk/ELF/InputSection.cpp

 template <class RelTy>
 void InputSection<ELFT>::copyRelocations(uint8_t *Buf, ArrayRef<RelTy> Rels) {
   InputSectionBase<ELFT> *RelocatedSection = getRelocatedSection();
 
   for (const RelTy &Rel : Rels) {
     uint32_t Type = Rel.getType(Config->Mips64EL);
     SymbolBody &Body = this->File->getRelocTargetSym(Rel);
 
-    RelTy *P = reinterpret_cast<RelTy *>(Buf);
+    Elf_Rela *P = reinterpret_cast<Elf_Rela *>(Buf);
     Buf += sizeof(RelTy);
 
+    if (Config->Rela)
+      P->r_addend = getAddend<ELFT>(Rel);
     P->r_offset = RelocatedSection->getOffset(Rel.r_offset);
     P->setSymbolAndType(Body.DynsymIndex, Type, Config->Mips64EL);
   }
 }
 
 // Page(Expr) is the page address of the expression Expr, defined
 // as (Expr & ~0xFFF). (This applies even if the machine page size
 // supported by the platform has a different value.)

lld/trunk/test/ELF/relocatable-symbols.s

 # REQUIRES: x86
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
 # RUN: ld.lld -r %t -o %tout
 # RUN: llvm-objdump -d %tout | FileCheck -check-prefix=DISASM %s
+# RUN: llvm-readobj -r %t | FileCheck -check-prefix=RELOC %s
 # RUN: llvm-readobj -symbols -r %tout | FileCheck -check-prefix=SYMBOL %s
 
 # DISASM:      _start:
 # DISASM-NEXT:   0: {{.*}} callq 0
 # DISASM-NEXT:   5: {{.*}} callq 0
 # DISASM-NEXT:   a: {{.*}} callq 0
 # DISASM-NEXT:   f: {{.*}} callq 0
 # DISASM-NEXT:  14: {{.*}} callq 0

 # DISASM-NEXT:  1: 90 nop
 # DISASM-NEXT:  2: 90 nop
 # DISASM-NEXT: Disassembly of section bar:
 # DISASM-NEXT: bar:
 # DISASM-NEXT:  0: 90 nop
 # DISASM-NEXT:  1: 90 nop
 # DISASM-NEXT:  2: 90 nop
 
+# RELOC:      Relocations [
+# RELOC-NEXT:   Section ({{.*}}) .rela.text {
+# RELOC-NEXT:     0x1 R_X86_64_PC32 __start_foo 0xFFFFFFFFFFFFFFFC
+# RELOC-NEXT:     0x6 R_X86_64_PC32 __stop_foo 0xFFFFFFFFFFFFFFFC
+# RELOC-NEXT:     0xB R_X86_64_PC32 __start_bar 0xFFFFFFFFFFFFFFFC
+# RELOC-NEXT:     0x10 R_X86_64_PC32 __stop_bar 0xFFFFFFFFFFFFFFFC
+# RELOC-NEXT:     0x15 R_X86_64_PC32 __start_doo 0xFFFFFFFFFFFFFFFC
+# RELOC-NEXT:     0x1A R_X86_64_PC32 __stop_doo 0xFFFFFFFFFFFFFFFC
+# RELOC-NEXT:     0x1F R_X86_64_PC32 __preinit_array_start 0xFFFFFFFFFFFFFFFC
+# RELOC-NEXT:     0x24 R_X86_64_PC32 __preinit_array_end 0xFFFFFFFFFFFFFFFC
+# RELOC-NEXT:     0x29 R_X86_64_PC32 __init_array_start 0xFFFFFFFFFFFFFFFC
+# RELOC-NEXT:     0x2E R_X86_64_PC32 __init_array_end 0xFFFFFFFFFFFFFFFC
+# RELOC-NEXT:     0x33 R_X86_64_PC32 __fini_array_start 0xFFFFFFFFFFFFFFFC
+# RELOC-NEXT:     0x38 R_X86_64_PC32 __fini_array_end 0xFFFFFFFFFFFFFFFC
+# RELOC-NEXT:   }
+# RELOC-NEXT: ]
+
 # SYMBOL:      Relocations [
 # SYMBOL-NEXT:  Section ({{.*}}) .rela.text {
-# SYMBOL-NEXT:     0x1 R_X86_64_PC32 __start_foo 0x0
-# SYMBOL-NEXT:     0x6 R_X86_64_PC32 __stop_foo 0x0
-# SYMBOL-NEXT:     0xB R_X86_64_PC32 __start_bar 0x0
-# SYMBOL-NEXT:     0x10 R_X86_64_PC32 __stop_bar 0x0
-# SYMBOL-NEXT:     0x15 R_X86_64_PC32 __start_doo 0x0
-# SYMBOL-NEXT:     0x1A R_X86_64_PC32 __stop_doo 0x0
-# SYMBOL-NEXT:     0x1F R_X86_64_PC32 __preinit_array_start 0x0
-# SYMBOL-NEXT:     0x24 R_X86_64_PC32 __preinit_array_end 0x0
-# SYMBOL-NEXT:     0x29 R_X86_64_PC32 __init_array_start 0x0
-# SYMBOL-NEXT:     0x2E R_X86_64_PC32 __init_array_end 0x0
-# SYMBOL-NEXT:     0x33 R_X86_64_PC32 __fini_array_start 0x0
-# SYMBOL-NEXT:     0x38 R_X86_64_PC32 __fini_array_end 0x0
+# SYMBOL-NEXT:     0x1 R_X86_64_PC32 __start_foo 0xFFFFFFFFFFFFFFFC
+# SYMBOL-NEXT:     0x6 R_X86_64_PC32 __stop_foo 0xFFFFFFFFFFFFFFFC
+# SYMBOL-NEXT:     0xB R_X86_64_PC32 __start_bar 0xFFFFFFFFFFFFFFFC
+# SYMBOL-NEXT:     0x10 R_X86_64_PC32 __stop_bar 0xFFFFFFFFFFFFFFFC
+# SYMBOL-NEXT:     0x15 R_X86_64_PC32 __start_doo 0xFFFFFFFFFFFFFFFC
+# SYMBOL-NEXT:     0x1A R_X86_64_PC32 __stop_doo 0xFFFFFFFFFFFFFFFC
+# SYMBOL-NEXT:     0x1F R_X86_64_PC32 __preinit_array_start 0xFFFFFFFFFFFFFFFC
+# SYMBOL-NEXT:     0x24 R_X86_64_PC32 __preinit_array_end 0xFFFFFFFFFFFFFFFC
+# SYMBOL-NEXT:     0x29 R_X86_64_PC32 __init_array_start 0xFFFFFFFFFFFFFFFC
+# SYMBOL-NEXT:     0x2E R_X86_64_PC32 __init_array_end 0xFFFFFFFFFFFFFFFC
+# SYMBOL-NEXT:     0x33 R_X86_64_PC32 __fini_array_start 0xFFFFFFFFFFFFFFFC
+# SYMBOL-NEXT:     0x38 R_X86_64_PC32 __fini_array_end 0xFFFFFFFFFFFFFFFC
 # SYMBOL-NEXT:   }
 # SYMBOL-NEXT: ]
 # SYMBOL:      Symbol {
 # SYMBOL:        Name: __fini_array_end
 # SYMBOL-NEXT:   Value: 0x0
 # SYMBOL-NEXT:   Size: 0
 # SYMBOL-NEXT:   Binding: Global
 # SYMBOL-NEXT:   Type: None