This is an archive of the discontinued LLVM Phabricator instance.

[lldb][tsan] Perform one map lookup instead of two (NFC)
ClosedPublic

Authored by vsk on Jul 29 2016, 5:12 PM.

Reviewers

compnerd
kubamracek

Commits

vsk retitled this revision from to [lldb][tsan] Perform one map lookup instead of two (NFC).

vsk updated this object.

vsk added a reviewer: kubamracek.

vsk added a subscriber: llvm-commits.

compnerd added a reviewer: compnerd.

This revision is now accepted and ready to land.Jul 29 2016, 6:30 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lldb/

trunk/

source/

Plugins/

InstrumentationRuntime/

ThreadSanitizer/

5 lines

Show First 20 Lines • Show All 329 Lines • ▼ Show 20 Lines	ConvertToStructuredArray(data, ".threads", ".thread_count", [process_sp, &thread_id_map] (ValueObjectSP o, StructuredData::Dictionary *dict) {
lldb_user_id = process_sp->AssignIndexIDToThread(thread_os_id);		lldb_user_id = process_sp->AssignIndexIDToThread(thread_os_id);
}		}

thread_id_map[thread_id] = lldb_user_id;		thread_id_map[thread_id] = lldb_user_id;
});		});
}		}

static user_id_t Renumber(uint64_t id, std::map<uint64_t, user_id_t> &thread_id_map) {		static user_id_t Renumber(uint64_t id, std::map<uint64_t, user_id_t> &thread_id_map) {
if (! thread_id_map.count(id))		auto IT = thread_id_map.find(id);
		if (IT == thread_id_map.end())
return 0;		return 0;

return thread_id_map[id];		return IT->second;
}		}

StructuredData::ObjectSP		StructuredData::ObjectSP
ThreadSanitizerRuntime::RetrieveReportData(ExecutionContextRef exe_ctx_ref)		ThreadSanitizerRuntime::RetrieveReportData(ExecutionContextRef exe_ctx_ref)
{		{
ProcessSP process_sp = GetProcessSP();		ProcessSP process_sp = GetProcessSP();
if (!process_sp)		if (!process_sp)
return StructuredData::ObjectSP();		return StructuredData::ObjectSP();
▲ Show 20 Lines • Show All 538 Lines • Show Last 20 Lines