This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Fix an MSVC x64 compiler error due to mismatched iterator types.
ClosedPublic

Authored by STL_MSFT on Jul 29 2016, 12:58 PM.

Details

Summary

Fix an MSVC x64 compiler error due to mismatched iterator types.

This was attempting to store a list<int, test_allocator<int>>::iterator in a list<int>::iterator. That isn't guaranteed by the Standard, and MSVC x64 rejects it (even though our list iterators are SCARY) because test_allocator has 32-bit size_type/difference_type, and our iterators take that into account even as they erase the allocator type itself.

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 66163.Jul 29 2016, 12:58 PM
STL_MSFT retitled this revision from to [libcxx] [test] Fix an MSVC x64 compiler error due to mismatched iterator types..
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
EricWF accepted this revision.Aug 2 2016, 10:57 PM
EricWF edited edge metadata.
This revision is now accepted and ready to land.Aug 2 2016, 10:57 PM
EricWF closed this revision.Aug 2 2016, 10:57 PM

r277574.