This is an archive of the discontinued LLVM Phabricator instance.

Ensure Ident_GNU_final is properly initialized in the Parser Initialize function
ClosedPublic

Authored by erichkeane on Jul 29 2016, 12:22 PM.

Details

Summary

My recent change to implement __final missed initializing the variable, which was caught by the Memory Sanitizer. This patch properly initializes the value to nullptr to ensure proper memory reads.

Diff Detail

Repository
rL LLVM

Event Timeline

erichkeane retitled this revision from to Ensure Ident_GNU_final is properly initialized in the Parser Initialize function.
erichkeane updated this object.
erichkeane set the repository for this revision to rL LLVM.
erichkeane added a project: Restricted Project.
andreybokhanko accepted this revision.Jul 29 2016, 12:32 PM
andreybokhanko edited edge metadata.

LGTM

I can commit this patch on Monday, when I will reach my work machine.

Andrey

This revision is now accepted and ready to land.Jul 29 2016, 12:32 PM
This revision was automatically updated to reflect the committed changes.