This is an archive of the discontinued LLVM Phabricator instance.

[CFLAA] Add getModRefBehavior() support to CFLAnders
ClosedPublic

Authored by grievejia on Jul 26 2016, 10:51 AM.

Details

Summary

This patch adds several getModRefBehavior() overloads to CFLAnders.

Hopefully this patch will make CFLAnders communicate better with its clients. I'd like to commit this patch in before dong any benchmarking work since it may help me get better numbers :)

Diff Detail

Event Timeline

grievejia updated this revision to Diff 65554.Jul 26 2016, 10:51 AM
grievejia retitled this revision from to [CFLAA] Add getModRefBehavior() support to CFLAnders.
grievejia updated this object.
grievejia added a subscriber: llvm-commits.
george.burgess.iv edited edge metadata.

Two nits, because people tend to do cleanups to llvm's range algos. Otherwise, LGTM. Thanks for the patch!

lib/Analysis/CFLAndersAliasAnalysis.cpp
873

Nit: llvm::any_of(RetParamAttributes, lambda) (and the two others below)

934

Nit: any_of(RetParamRelations, lambda) (and below, for all_of)

This revision is now accepted and ready to land.Jul 26 2016, 9:53 PM
grievejia updated this revision to Diff 65743.Jul 27 2016, 7:45 AM
grievejia edited edge metadata.

Use llvm range API instead.

Also, fix CFLSteens that was accidentally broken in the last version of the path.

This revision was automatically updated to reflect the committed changes.