This is an archive of the discontinued LLVM Phabricator instance.

Move assert as early as possible.
ClosedPublic

Authored by hiraditya on Jul 26 2016, 9:13 AM.

Diff Detail

Event Timeline

hiraditya updated this revision to Diff 65539.Jul 26 2016, 9:13 AM
hiraditya retitled this revision from to Move assert as early as possible..
hiraditya updated this object.
hiraditya added reviewers: hfinkel, sanjoy.
sanjoy accepted this revision.Jul 26 2016, 11:11 AM
sanjoy edited edge metadata.

lgtm with a comment inline

llvm/include/llvm/Analysis/LoopInfoImpl.h
249

Since you're touching this code, can you (in a separate change) change this loop to use std::any_of? Even better would be if you add a children function (that directly returns a range) and use llvm::any_of.

This revision is now accepted and ready to land.Jul 26 2016, 11:11 AM
This revision was automatically updated to reflect the committed changes.
sebpop added inline comments.Jul 26 2016, 9:44 PM
llvm/include/llvm/Analysis/LoopInfoImpl.h
249