This is an archive of the discontinued LLVM Phabricator instance.

LiveIntervals: add removeRegUnit
ClosedPublic

Authored by nhaehnle on Jul 26 2016, 4:10 AM.

Details

Summary

See D22198 for the motivation: We have a pass that uses LiveIntervals anyway,
and there is now a requirement to track a physical register that is not
usually tracked at this point of the compilation. The pass also introduces
instructions that affect this physical register, but we want to preserve
LiveIntervals.

Rather than add brittle and rarely exercised code to keep the tracking of
the physical register intact, we want to just remove the corresponding
LiveRange -- it didn't exist before anyway, and subsequent passes don't
expect it to be there.

Diff Detail

Event Timeline

nhaehnle updated this revision to Diff 65491.Jul 26 2016, 4:10 AM
nhaehnle retitled this revision from to LiveIntervals: add removeRegUnit.
nhaehnle updated this object.
nhaehnle added reviewers: MatzeB, arsenm.
nhaehnle added a subscriber: llvm-commits.
MatzeB accepted this revision.Jul 26 2016, 11:04 AM
MatzeB edited edge metadata.

LGTM with nitpick:

include/llvm/CodeGen/LiveIntervalAnalysis.h
395–396

Please do not repeat the method name in the doxygen comment.

This revision is now accepted and ready to land.Jul 26 2016, 11:04 AM
This revision was automatically updated to reflect the committed changes.