This is an archive of the discontinued LLVM Phabricator instance.

Define a Module Map for DebugInfo/MSF
ClosedPublic

Authored by zturner on Jul 25 2016, 10:59 AM.

Details

Summary

Modules build doesn't seem to work on windows with clang-cl, so I can't test this. Can you confirm that this looks correct? The reason for the error seems to be that class StreamRef was moved from DebugInfo/CodeView to DebugInfo/Msf.

I don't know why the compiler error still referred to DebugInfo_CodeView

Diff Detail

Repository
rL LLVM

Event Timeline

zturner updated this revision to Diff 65381.Jul 25 2016, 10:59 AM
zturner retitled this revision from to Define a Module Map for DebugInfo/MSF.
zturner updated this object.
zturner added a reviewer: aprantl.
zturner added a subscriber: llvm-commits.
aprantl accepted this revision.Jul 25 2016, 11:22 AM
aprantl edited edge metadata.

Confirmed that this patch makes building lib/libLLVMDebugInfoCodeView.a succeed again.
LGTM, thanks!

This revision is now accepted and ready to land.Jul 25 2016, 11:22 AM
This revision was automatically updated to reflect the committed changes.