This is an archive of the discontinued LLVM Phabricator instance.

[mips] sgtu, s[rl]l, sra, dnegu, neg instruction aliases
ClosedPublic

Authored by sdardis on Jul 25 2016, 5:57 AM.

Details

Summary

Add the instruction alias sgtu (register form only), two operand forms of
s[rl]l and sra, and missing single/two operand forms of dnegu/neg.

Diff Detail

Repository
rL LLVM

Event Timeline

sdardis updated this revision to Diff 65333.Jul 25 2016, 5:57 AM
sdardis retitled this revision from to [mips] sgtu, s[rl]l, sra, dnegu, neg instruction aliases.
sdardis updated this object.
sdardis added reviewers: dsanders, vkalintiris.
sdardis set the repository for this revision to rL LLVM.
sdardis added a subscriber: llvm-commits.
dsanders accepted this revision.Jul 25 2016, 8:55 AM
dsanders edited edge metadata.

LGTM

lib/Target/Mips/MipsInstrInfo.td
2329–2334 ↗(On Diff #65333)

It's a shame that InstAlias doesn't have the same TwoOperandAliasConstraint member that Instruction has. We wouldn't need to repeat ourselves as much if it did.

This revision is now accepted and ready to land.Jul 25 2016, 8:55 AM
This revision was automatically updated to reflect the committed changes.