This is an archive of the discontinued LLVM Phabricator instance.

[mips][ias] Enable IAS by default for N64 on Debian mips64el.
ClosedPublic

Authored by dsanders on Jul 22 2016, 7:30 AM.

Details

Reviewers
sdardis
Summary

Unfortunately we can't enable it for all N64 because it is not yet possible to
distinguish N32 from N64 from the triple on other environments.

N64 has been confirmed to produce identical (within reason) objects to GAS
during stage 2 of compiler recursion on N64-abi Fedora. Unfortunately,
Fedora's triples do not distinguish N32 from N64 so I can't enable it by
default there. I'm currently repeating this testing for Debian mips64el but
it's very unlikely to produce a different result.

Diff Detail

Event Timeline

dsanders updated this revision to Diff 65076.Jul 22 2016, 7:30 AM
dsanders retitled this revision from to [mips][ias] Enable IAS by default for N64 on Debian mips64el..
dsanders updated this object.
dsanders added a reviewer: sdardis.
dsanders added a subscriber: cfe-commits.
sdardis accepted this revision.Jul 22 2016, 7:44 AM
sdardis edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Jul 22 2016, 7:44 AM

Yes, I think you should also reflect mpf's comment here too.

Actually, seeing your reply on the related patch, keep the comment as it reflects trunk.

sdardis closed this revision.Sep 15 2016, 7:10 AM

Committed as rL281610.