This is an archive of the discontinued LLVM Phabricator instance.

[mips][ias] Enable IAS by default for N64 on Debian mips64el.
ClosedPublic

Authored by dsanders on Jul 22 2016, 7:29 AM.

Details

Reviewers
sdardis
Summary

Unfortunately we can't enable it for all N64 because it is not yet possible to
distinguish N32 from N64.

N64 has been confirmed to produce identical (within reason) objects to GAS
during stage 2 of compiler recursion on N64-abit Fedora. Unfortunately,
Fedora's triples do not distinguish N32 from N64 so I can't enable it by
default there. I'm currently repeating this testing for Debian mips64el but
it's very unlikely to produce a different result.

Diff Detail

Event Timeline

dsanders updated this revision to Diff 65075.Jul 22 2016, 7:29 AM
dsanders retitled this revision from to [mips][ias] Enable IAS by default for N64 on Debian mips64el..
dsanders updated this object.
dsanders added a reviewer: sdardis.
dsanders added a subscriber: llvm-commits.
mpf added a subscriber: mpf.Jul 22 2016, 7:36 AM

I'm not sure there is any subtlety between all n64 and debian mips64/mips64el. If someone uses a manually modified triple to have gnuabi64 along with a -mabi=64 option then n64 will get IAS enabled. If you use a 32bit triple with a -mabi=64 then it won't be enabled.

I would change the comment to be:

// Enable IAS by default if the environment encodes the ABI explicitly

Matthew

In D22678#492835, @mpf wrote:

I'm not sure there is any subtlety between all n64 and debian mips64/mips64el. If someone uses a manually modified triple to have gnuabi64 along with a -mabi=64 option then n64 will get IAS enabled. If you use a 32bit triple with a -mabi=64 then it won't be enabled.

I would change the comment to be:

// Enable IAS by default if the environment encodes the ABI explicitly

Matthew

I'm currently treating support for Debian mips64el and the more general ABI-in-triples work as fully independent pieces of work. The current comment is intended to be correct for the current LLVM trunk and I was planning to change the comment to something like your suggestion when the ABI-in-triples work lands and I enable IAS for N64 in general.

sdardis accepted this revision.Jul 22 2016, 8:21 AM
sdardis edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Jul 22 2016, 8:21 AM
sdardis closed this revision.Sep 15 2016, 6:24 AM

Taking over this patch, committed as rL281607 .