This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Mark bucket_count() equality assertions as nonportable.
ClosedPublic

Authored by STL_MSFT on Jul 8 2016, 12:28 PM.

Details

Summary

Mark bucket_count() equality assertions as nonportable.

There's nothing in the Standard preventing an unordered container from always having a bucket count of at least 1000, or whatever. Any assertions for exact equality are nonportable and should be marked as such.

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 63292.Jul 8 2016, 12:28 PM
STL_MSFT retitled this revision from to [libcxx] [test] Mark bucket_count() equality assertions as nonportable..
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
EricWF accepted this revision.Jul 24 2016, 5:32 PM
EricWF edited edge metadata.

It's not great that our tests have so many non-portable assertions. Normally we want to avoid writing non-standard assertions at all, but there doesn't seem to be a way around it here.
However there's no easy way to fix that here, so thank you for making all these tests portable.

I wish there weren't so many changes though :-(

This revision is now accepted and ready to land.Jul 24 2016, 5:32 PM
EricWF closed this revision.Jul 24 2016, 5:34 PM

r276593.