Page MenuHomePhabricator

[CFLAA] Simplify CFLGraphBuilder by removing the escaped value set and external value set
ClosedPublic

Authored by grievejia on Jul 5 2016, 1:11 PM.

Details

Summary

This is a code cleanup patch. No functionality change is introduced.

Previously, CFLGraphBuilder maintained 5 auxiliary structures in addition to the CFLGraph under construction. Among those five structures, the escaped value set and the external value set were irreplaceable when they were first introduced, but now their use cases can be completely covered by InstantiatedAttrs. We could simplify CFLGraphBuilder (as well as its clients) by removing those two sets.

Diff Detail

Repository
rL LLVM

Event Timeline

grievejia updated this revision to Diff 62779.Jul 5 2016, 1:11 PM
grievejia retitled this revision from to [CFLAA] Simplify CFLGraphBuilder by removing the escaped value set and external value set.
grievejia updated this object.
grievejia added a subscriber: llvm-commits.
grievejia updated this revision to Diff 62980.Jul 6 2016, 2:41 PM

Rebased on master

Sorry for the latency on these reviews: LGTM. Will commit later today.

This revision was automatically updated to reflect the committed changes.