The code generation should be independent of the debug info.
Details
Diff Detail
Event Timeline
test/DebugInfo/COFF/local-variables.ll | ||
---|---|---|
30–60 | It would probably be a good idea to capture 52, 44 and 48 in FileCheck variables so that the test is less sensitive to changes. |
test/DebugInfo/COFF/local-variables.ll | ||
---|---|---|
30–59 | You should use these variables down below |
test/DebugInfo/COFF/local-variables.ll | ||
---|---|---|
30–59 | The tests down below are separate tests (OBJ v.s. ASM), and these variables has no reuse in that test. So do you mean that I do not check these offset values at all in the OBJ tests? I can remove the check for numbers if that is what you meant. |
LGTM with the suggested changes to local-variables.ll undone.
test/DebugInfo/COFF/local-variables.ll | ||
---|---|---|
30–59 | Ah, nevermind. In that case the test is better off with an explicit offset... Sorry about that! |
You should use these variables down below