This is an archive of the discontinued LLVM Phabricator instance.

[ELF] - Remove Config->ZDefs flag.
ClosedPublic

Authored by grimar on Jun 28 2016, 3:17 AM.

Details

Diff Detail

Event Timeline

grimar updated this revision to Diff 62072.Jun 28 2016, 3:17 AM
grimar retitled this revision from to [ELF] - Remove Config->ZDefs flag..
grimar updated this object.
grimar added reviewers: ruiu, rafael.
grimar added subscribers: llvm-commits, grimar.
grimar updated this revision to Diff 62073.Jun 28 2016, 3:21 AM
  • Minor update
grimar updated this revision to Diff 62074.Jun 28 2016, 3:29 AM
  • One more minor update.
ruiu added inline comments.Jun 28 2016, 4:36 AM
ELF/Driver.cpp
366
Config->NoUndefined = Args.hasArg(OPT_no_undefined) || hasZOption(Args, "defs")

would be better.

grimar added inline comments.Jun 28 2016, 4:38 AM
ELF/Driver.cpp
366

Ok. I wanted to leave -z group along, but that also works.

ruiu added inline comments.Jun 28 2016, 4:42 AM
ELF/Driver.cpp
366

I understand, but |= seems too subtle.

grimar updated this revision to Diff 62075.Jun 28 2016, 4:53 AM
  • Addressed review comments.
ruiu accepted this revision.Jun 28 2016, 5:09 AM
ruiu edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jun 28 2016, 5:09 AM
This revision was automatically updated to reflect the committed changes.