Page MenuHomePhabricator

Refactor ELF type inference functions.

Authored by ruiu on Jun 27 2016, 10:47 PM.



Previously, we initialized Config->EKind and Config->EMachine when
we instantiate ELF objects. That was not an ideal location to do that
because the logic was buried too deep inside a concrete logic.

This patch moves the code to the driver so that the initialization
becomes explicit.

Diff Detail


Event Timeline

ruiu updated this revision to Diff 62058.Jun 27 2016, 10:47 PM
ruiu retitled this revision from to Refactor ELF type inference functions..
ruiu updated this object.
ruiu added a reviewer: davide.
ruiu added a subscriber: llvm-commits.
grimar added a subscriber: grimar.Jun 27 2016, 11:34 PM
davide accepted this revision.Jun 28 2016, 2:43 PM
davide edited edge metadata.

looks good

277 ↗(On Diff #62058)

spurious whiteline?

This revision is now accepted and ready to land.Jun 28 2016, 2:43 PM
rafael accepted this revision.Jun 28 2016, 6:07 PM
rafael added a reviewer: rafael.
rafael added a subscriber: rafael.

LGTM too.

Should probably make it easier to infer EKind from bitcode files.

This revision was automatically updated to reflect the committed changes.