This is an archive of the discontinued LLVM Phabricator instance.

Differential D21635

[llgo] add llgo source path to LLVM_GO_PACKAGES
ClosedPublic

Authored by axw on Jun 22 2016, 10:51 PM.

Details

Reviewers
pcc
Commits
rG5fdb3b89da10: [llgo] add llgo source path to LLVM_GO_PACKAGES
rL276828: [llgo] add llgo source path to LLVM_GO_PACKAGES
Summary

To support the use of LLVM_EXTERNAL_LLGO_SOURCE_DIR,
with llgo situated in a location other than tools/llgo,
we add the llgo source directory to LLVM_GO_PACKAGES.

Diff Detail

Event Timeline

axw updated this revision to Diff 61641.Jun 22 2016, 10:51 PM
axw retitled this revision from to [llgo] add llgo source path to LLVM_GO_PACKAGES.
axw updated this object.
axw added a reviewer: pcc.
axw added a subscriber: llvm-commits.
axw added a parent revision: D21634: [llvm-go] parameterize $GOPATH construction.Jun 22 2016, 10:52 PM
axw added a comment.Jul 26 2016, 7:52 PM

@pcc ping?

pcc accepted this revision.Jul 26 2016, 7:58 PM
pcc edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jul 26 2016, 7:58 PM
axw closed this revision.Jul 26 2016, 8:08 PM

Revision Contents

PathSize
2 lines

Diff 61641

CMakeLists.txt

include(ExternalProject) include(ExternalProject)
include(ProcessorCount) include(ProcessorCount)
# Provide a config.h which exposes build system information. # Provide a config.h which exposes build system information.
configure_file( configure_file(
cmd/gllgo/config.h.cmake cmd/gllgo/config.h.cmake
${CMAKE_CURRENT_BINARY_DIR}/cmd/gllgo/config.h) ${CMAKE_CURRENT_BINARY_DIR}/cmd/gllgo/config.h)
include_directories(${CMAKE_CURRENT_BINARY_DIR}/cmd/gllgo) include_directories(${CMAKE_CURRENT_BINARY_DIR}/cmd/gllgo)
list(APPEND LLVM_GO_PACKAGES "llvm.org/llgo=${CMAKE_CURRENT_SOURCE_DIR}")
llvm_add_go_executable(llgo llvm.org/llgo/cmd/gllgo ALL DEPENDS llvm_add_go_executable(llgo llvm.org/llgo/cmd/gllgo ALL DEPENDS
build/context.go build/context.go
cmd/gllgo/gllgo.go cmd/gllgo/gllgo.go
debug/debug.go debug/debug.go
driver/parser.go driver/parser.go
irgen/annotations.go irgen/annotations.go
irgen/attribute.go irgen/attribute.go
irgen/builtins.go irgen/builtins.go
▲ Show 20 Lines • Show All 245 Lines • Show Last 20 Lines