Page MenuHomePhabricator

[zorg] Replace SKIP_* in sanitizer buildbot config by conditionals based on ARCH.
ClosedPublic

Authored by koriakin on Jun 22 2016, 5:17 AM.

Details

Summary

Currently, the final check-msan/scuda/... step is controlled by SKIP_MSAN/...
environment variables, set based on buildbot config. However, these variables
have a default value of 1 set in the bash script, making the tests never
executed.

On the other hand, the other two check-msan/... steps are executed iff
ARCH == x86_64, skipping the tests on all other architectures.

Let's nuke the SKIP_* variables, and make all check-msan/... steps
conditional on the ARCH, as determined by the bash script, but extend
it to recognize other architectures that support msan (and other sanitizers).
Also make tsan likewise conditional (it's not supported eg. on i386).

Diff Detail

Repository
rL LLVM

Event Timeline

koriakin retitled this revision from to [zorg] Replace SKIP_* in sanitizer buildbot config by conditionals based on ARCH..
koriakin updated this object.
koriakin added reviewers: kcc, seurer.
koriakin set the repository for this revision to rL LLVM.
koriakin added a project: Restricted Project.
koriakin added a subscriber: llvm-commits.

Beware: I haven't tested this change (I have no idea how to do that).

seurer edited edge metadata.Jun 22 2016, 6:43 AM

Looks pretty good. For completeness sake how about adding CHECK_ASAN and CHECK_UBSAN and handling CHECK_LIBCXX and
CHECK_LLD the same way as the others?

Looks pretty good. For completeness sake how about adding CHECK_ASAN and CHECK_UBSAN and handling CHECK_LIBCXX and
CHECK_LLD the same way as the others?

I'll throw in CHECK_ASAN/UBSAN (though they're not very useful - all arches that have a sanitizer buildbot support these). However, CHECK_LIBCXX and CHECK_LLD don't appear to be used in the script at all - should I remove them?

koriakin edited edge metadata.

Added CHECK_ASAN and CHECK_UBSAN, removed CHECK_LLD and CHECK_LIBCXX from the bash script.

eugenis accepted this revision.Jun 22 2016, 1:26 PM
eugenis edited edge metadata.

Looks great.

This revision is now accepted and ready to land.Jun 22 2016, 1:26 PM

One more question: does something special have to be done to deploy it to buildbots, or will they fetch the change on their own?

This revision was automatically updated to reflect the committed changes.

This is the great thing about these scripts: they are fetched by buildbots directly from the llvm repo. No buildmaster restart is needed.