Page MenuHomePhabricator

[libcxx] [test] Fix an operator precedence mistake in valarray.unary/not.pass.cpp.
ClosedPublic

Authored by STL_MSFT on Jun 21 2016, 5:56 PM.

Details

Summary

Fix an operator precedence mistake in valarray.unary/not.pass.cpp. This one was sneaky - the test happened to be passing, but totally by accident.

You can thank MSVC warning C4805 "'==': unsafe mix of type 'bool' and type 'T' in operation" for this one.

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 61477.Jun 21 2016, 5:56 PM
STL_MSFT retitled this revision from to [libcxx] [test] Fix an operator precedence mistake in valarray.unary/not.pass.cpp..
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
EricWF accepted this revision.Jun 21 2016, 6:10 PM
EricWF edited edge metadata.

Good catch. Thanks.

This revision is now accepted and ready to land.Jun 21 2016, 6:10 PM
EricWF closed this revision.Jun 21 2016, 6:11 PM

r273352.