This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Refactor Thumb2 mul instruction descriptions
ClosedPublic

Authored by samparker on Jun 21 2016, 2:16 AM.

Details

Summary

No functional changes. Just created wrapper classes around the 3 and 4 reg mult and mac instruction classes.

Diff Detail

Repository
rL LLVM

Event Timeline

samparker updated this revision to Diff 61348.Jun 21 2016, 2:16 AM
samparker retitled this revision from to [ARM] Refactor Thumb2 mul instruction descriptions.
samparker updated this object.
rengolin accepted this revision.Jun 28 2016, 5:04 AM
rengolin added a reviewer: rengolin.

Hi Sam,

Sorry it took so long, this is a complicated patch. :)

All in all, this is a great patch. Removes a lot of duplication and makes it less error prone. Thanks for doing this work.

I couldn't see anything wrong with it, though I may have missed in the huge list of changes. I'm assuming this passes all tests (internal and external), so, LGTM.

Thanks!
--renato

This revision is now accepted and ready to land.Jun 28 2016, 5:04 AM
This revision was automatically updated to reflect the committed changes.
samparker updated this revision to Diff 63478.Jul 11 2016, 2:16 AM
samparker edited edge metadata.
samparker removed rL LLVM as the repository for this revision.

Original commit was reverted due to the thumb umaal description being incorrect and there was no test case to catch it. Updated patch corrects the bug and adds testing for t2UMAAL

Hi Renato,

Are you able to see the change clearly now? I'm not really sure how to use this interface so can't tell if you can see the incremental change.

cheers,
sam