[polly] Respect LLVM_INSTALL_TOOLCHAIN_ONLY

[Eugene.Zelenko]

Summary

Only shared library should be installed when LLVM_INSTALL_TOOLCHAIN_ONLY=ON.

I'd like to remove empty autoconf directory in same commit.

I checked this patch on my own build on RHEL 6. Regressions were OK.

[grosser]

Hi Eugene,

this patch LGTM, but please remove the autoconf directory in a separate commit. Both issues are independent and consequently should be addressed with independent commits. If you have commit rights, feel free to go ahead.

[Eugene.Zelenko]

I'll commit only CMake files changes.

[grosser]

In D21543#463483, @Eugene.Zelenko wrote:

I'll commit only CMake files changes.

Does this mean you do not plan to drop the autoconf directory any more? What was the reason you decided against it? From my perspective you can drop it without further review. The only thing I asked for to use different commits. I hope this did not discourage you.

[Eugene.Zelenko]

In D21543#463822, @grosser wrote:

In D21543#463483, @Eugene.Zelenko wrote:

I'll commit only CMake files changes.

Does this mean you do not plan to drop the autoconf directory any more? What was the reason you decided against it? From my perspective you can drop it without further review. The only thing I asked for to use different commits. I hope this did not discourage you.

Problem that removing autoconf directory require to commit ., and this conflicts with uncommitted D21488.

[grosser]

In D21543#463824, @Eugene.Zelenko wrote:

In D21543#463822, @grosser wrote:

In D21543#463483, @Eugene.Zelenko wrote:

I'll commit only CMake files changes.

Does this mean you do not plan to drop the autoconf directory any more? What was the reason you decided against it? From my perspective you can drop it without further review. The only thing I asked for to use different commits. I hope this did not discourage you.

Problem that removing autoconf directory require to commit ., and this conflicts with uncommitted D21488.

OK. So this seems to mostly be a shortcoming of the version control system. As the change is trivial and committing it seems to cause complications on your side, I just committed this myself in r273338. Thanks for reporting the leftover directory.

Best,
Tobias

PS: It seems you are still using svn. You might want consider the use of 'git', which makes working with patches a lot easier. This comes often handy when addressing review comments and working with more than one patch at a time.

[Eugene.Zelenko]

Thank you for suggestion! Actually I tried to use git for Include What You Use, but SubVersion is still easier for me because of past CVS background.

CMakeLists.txt

   ${CMAKE_CURRENT_BINARY_DIR}/include
   )
 
-install(DIRECTORY include/
-  DESTINATION include
-  FILES_MATCHING
-  PATTERN "*.h"
-  PATTERN ".svn" EXCLUDE
-  )
+if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
+  install(DIRECTORY include/
+    DESTINATION include
+    FILES_MATCHING
+    PATTERN "*.h"
+    PATTERN ".svn" EXCLUDE
+    )
 
   install(DIRECTORY ${POLLY_BINARY_DIR}/include/
     DESTINATION include
     FILES_MATCHING
     PATTERN "*.h"
     PATTERN "CMakeFiles" EXCLUDE
     PATTERN ".svn" EXCLUDE
     )
+endif()
 
 add_definitions( -D_GNU_SOURCE )
 

cmake/polly_macros.cmake

   if( LLVM_LINK_COMPONENTS )
     llvm_config(${name} ${LLVM_LINK_COMPONENTS})
   endif( LLVM_LINK_COMPONENTS )
-  install(TARGETS ${name}
-    EXPORT LLVMExports
-    LIBRARY DESTINATION lib${LLVM_LIBDIR_SUFFIX}
-    ARCHIVE DESTINATION lib${LLVM_LIBDIR_SUFFIX})
+  if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY OR ${name} STREQUAL "LLVMPolly")
+    install(TARGETS ${name}
+      EXPORT LLVMExports
+      LIBRARY DESTINATION lib${LLVM_LIBDIR_SUFFIX}
+      ARCHIVE DESTINATION lib${LLVM_LIBDIR_SUFFIX})
+  endif()
   set_property(GLOBAL APPEND PROPERTY LLVM_EXPORTS ${name})
 endmacro(add_polly_library)