Page MenuHomePhabricator

[codeview] Remove unused parameter.
ClosedPublic

Authored by ruiu on Jun 16 2016, 7:07 AM.

Details

Summary

I need to pass raw CVRecord to the visitor callback functions to
compute hash values, becaues in some cases we have to compute a
hash over the entire record as byte array rather than for some
field. But I don't want to make the callbacks to have tons of
parameters. In this patch, the first unused parameter is removed
from callbacks.

Diff Detail

Event Timeline

ruiu updated this revision to Diff 60970.Jun 16 2016, 7:07 AM
ruiu retitled this revision from to [codeview] Remove unused parameter..
ruiu updated this object.
ruiu added a reviewer: zturner.
ruiu added a subscriber: llvm-commits.
zturner accepted this revision.Jun 16 2016, 7:42 AM
zturner edited edge metadata.

This should be fine because I believe the record structure contains the leaf kind anyway. Make sure you try to build the DebugInfoPDBTests target. It's not built by default, and this change might require fixing some things in that project.

This revision is now accepted and ready to land.Jun 16 2016, 7:42 AM
ruiu added a comment.Jun 16 2016, 7:47 AM

DebugInfoPDBTests built fine and ninja check passed. Submitting.

This revision was automatically updated to reflect the committed changes.