Page MenuHomePhabricator

[Codegen] Reorganize PICLevel
ClosedPublic

Authored by davide on Jun 15 2016, 11:55 AM.

Details

Summary

See http://reviews.llvm.org/D21100 for context/rationale behind this change.
CC:ing PPC as it seems to be the only user of this feature.

Diff Detail

Repository
rL LLVM

Event Timeline

davide updated this revision to Diff 60872.Jun 15 2016, 11:55 AM
davide retitled this revision from to [Codegen] Reorganize PICLevel.
davide updated this object.
davide added reviewers: rafael, jhibbits, hfinkel.
davide added a subscriber: llvm-commits.
rafael edited edge metadata.Jun 16 2016, 9:39 AM
rafael added a subscriber: rafael.

LGTM with a comment in CodeGen.h saying this maps -fpic/-fPIC. Please
also improve the commit message to mention that Default is being
converted to NotPIC so that target independent code can reason about
this.

This revision was automatically updated to reflect the committed changes.