redefinition of '__true_type' struct __true_type {}; - Bug 27991

[CrisCristescu]

Summary

There is an error when building self-hosted clang with modules:
/home/biancacr/clang_build_/src/tools/clang/test/Modules/Inputs/PR27991/vector:2:8: error: redefinition of 'true_type'
struct true_type {};

^

This is cause by include cycles when building the module.
This patch solves the issue by creating only one module which contains both the files that created the cycle includes.

[rsmith]

Makes sense to me.

[rsmith]

include/llvm/module.modulemap

121–126

You should be able to remove all of these too.

[v.g.vassilev]

Landed in r272877.

include/llvm/module.modulemap

121–126

Done.

include/llvm/module.modulemap

module LLVM_ExecutionEngine {
   // Exclude these; they're intended to be included into only a single
   // translation unit (or none) and aren't part of this module.
   exclude header "ExecutionEngine/JIT.h"
   exclude header "ExecutionEngine/MCJIT.h"
   exclude header "ExecutionEngine/Interpreter.h"
   exclude header "ExecutionEngine/OrcMCJITReplacement.h"
 }
 
+module LLVM_Pass {
+  module Pass {
+    // PassSupport.h and PassAnalysisSupport.h are made available only through
+    // Pass.h.
+    header "Pass.h"
+    header "PassSupport.h"
+    header "PassAnalysisSupport.h"
+    export *
+  }
+
+  module PassRegistry { header "PassRegistry.h" export * }
+  module InitializePasses { header "InitializePasses.h" export * }
+}
+
 module LLVM_IR {
   requires cplusplus
 
   // FIXME: Is this the right place for these?
   module Pass { header "Pass.h" export * }
   module PassSupport { header "PassSupport.h" export * }
   module PassAnalysisSupport { header "PassAnalysisSupport.h" export * }
   module PassRegistry { header "PassRegistry.h" export * }
   module InitializePasses { header "InitializePasses.h" export * }
 
   umbrella "IR"
   module * { export * }
 
   // These are intended for (repeated) textual inclusion.
   textual header "IR/DebugInfoFlags.def"
   textual header "IR/Instruction.def"
   textual header "IR/Metadata.def"