Added v_mad_16 instruction definition.
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
The commit subject should be be prefixed with AMDGPU:
lib/Target/AMDGPU/VIInstructions.td | ||
---|---|---|
78–83 | Can we also add a pattern and a test with this patch? |
This pattern has been tested in LIT test mad_uint24.ll, which is a part of fp16 implementation.
lib/Target/AMDGPU/VIInstructions.td | ||
---|---|---|
281–284 | Yes, we may not need the pattern. For this patch, we may only need to add the instruction definition for the time being. |
lib/Target/AMDGPU/VIInstructions.td | ||
---|---|---|
87 | Could you please say in more details? Thanks! |
The v_mad_f16 instruction is also missing
lib/Target/AMDGPU/VIInstructions.td | ||
---|---|---|
82–83 | These aren't the opcode values I see in the manual |
- Modified opcode for v_mad_u16, v_mad_i16 to make it consistant with the GCN manual.
- Added v_mad_f16 instruction definition.
With the capitalization fix LGTM
lib/Target/AMDGPU/VIInstructions.td | ||
---|---|---|
82 | All of the other opcodes use lower case letters in the hex. |
The unsigned version should be also added