Page MenuHomePhabricator

[LibFuzzer] Fix `FuzzerMutate.ShuffleBytes2` unit test on OSX.

Authored by delcypher on Jun 14 2016, 4:03 PM.



[LibFuzzer] Fix FuzzerMutate.ShuffleBytes2 unit test on OSX.

The FuzzerMutate.ShuffleBytes2 unit test was failing on
OSX due to the implementation of std::random_shuffle()
being different between libcxx and libstdc++.

@kcc has decided (see it is acceptable
for there to be different mutation behavior on different platforms so
this commit just adjusts the test to perform the minimum number of
iterations (that is a power of 2) to see all the mutations the unit test
is looking for.

Diff Detail


Event Timeline

delcypher updated this revision to Diff 60777.Jun 14 2016, 4:03 PM
delcypher retitled this revision from to [LibFuzzer] Fix `FuzzerMutate.ShuffleBytes2` unit test on OSX..
delcypher updated this object.
delcypher added reviewers: kcc, aizatsky.
delcypher added subscribers: kcc, aizatsky, zaks.anna and 3 others.
kcc accepted this revision.Jun 14 2016, 6:11 PM
kcc edited edge metadata.


262 ↗(On Diff #60777)

the comment is not very useful, please remove it.
The commit message will be enough.

This revision is now accepted and ready to land.Jun 14 2016, 6:11 PM
delcypher updated this revision to Diff 60783.Jun 14 2016, 6:45 PM
delcypher edited edge metadata.

Remove comment.

This revision was automatically updated to reflect the committed changes.