Remove unused wait/release code.

[tlwilmar]

Summary

Cleanup - unused code removal.
TODO: consider to remove (replace with flag class methods) also
kmp_wait_64 and kmp_release_64 routines.

Patch by Andrey Churbanov

[hbae]

LGTM.

[tlwilmar]

No, we just use a different mechanism now for all the other flag types (template classes in kmp_wait_release.h). Eventually 64 bit flags might be always be able to use the same mechanism (and some of them already do), but it requires more code refactoring for cases that don’t currently use the flag templates.

From: Yonghong Yan [mailto:[e-mail]]
Sent: Tuesday, June 14, 2016 2:44 PM
To: [e-mail]; Peyton, Jonathan L <[e-mail]>
Cc: Wilmarth, Terry L <[e-mail]>; Bae, Hansang <[e-mail]>; [e-mail]
Subject: Re: [Openmp-commits] [PATCH] D21332: Remove unused wait/release code.

Does that mean 32-bit support is being removed? how about those *_4 and *_4u ones, e.g. kmpc_dispatch_fini_4u? I know those kmpc are compiler interfaces.

If no 32-bit, how about also kmp_wait_64 to kmp_wait ?

runtime/src/dllexports

%endif
 
         # Symbols for MS mutual detection:
         _You_must_link_with_exactly_one_OpenMP_library    DATA
         _You_must_link_with_Intel_OpenMP_library          DATA
         %ifdef msvc_compat
             _You_must_link_with_Microsoft_OpenMP_library  DATA
         %endif
 
-        __kmp_wait_32
         __kmp_wait_64
-        __kmp_wait_oncore
-        __kmp_release_32
         __kmp_release_64
-        __kmp_release_oncore
 
 
 #    VT_getthid                              1
 #    vtgthid                                 2
 
     __kmpc_atomic_4                         100
     __kmpc_atomic_8                         101
     __kmpc_atomic_fixed4_add                102

runtime/src/exports_so.txt

#if USE_ITT_BUILD
         __kmp_get_reduce_method;
         __kmp_invoke_microtask;
         __kmp_itt_fini_ittlib;
         __kmp_itt_init_ittlib;
         __kmp_launch_monitor;
         __kmp_launch_worker;
         __kmp_reap_monitor;
         __kmp_reap_worker;
-        __kmp_release_32;
         __kmp_release_64;
-        __kmp_release_oncore;
-        __kmp_wait_32;
         __kmp_wait_64;
-        __kmp_wait_oncore;
         __kmp_wait_yield_4;
 
         # ittnotify symbols to be used by debugger
         __kmp_itt_fini_ittlib;
         __kmp_itt_init_ittlib;
 #endif /* USE_ITT_BUILD */
 
     local: # Non-exported symbols.

runtime/src/kmp.h

 extern kmp_uint32 __kmp_ge_4(  kmp_uint32 value, kmp_uint32 checker );
 extern kmp_uint32 __kmp_le_4(  kmp_uint32 value, kmp_uint32 checker );
 extern kmp_uint32 __kmp_wait_yield_4( kmp_uint32 volatile * spinner, kmp_uint32 checker, kmp_uint32 (*pred) (kmp_uint32, kmp_uint32), void * obj );
 extern void __kmp_wait_yield_4_ptr( void * spinner, kmp_uint32 checker, kmp_uint32 (* pred)( void *, kmp_uint32 ), void * obj );
 
 class kmp_flag_32;
 class kmp_flag_64;
 class kmp_flag_oncore;
-extern void __kmp_wait_32(kmp_info_t *this_thr, kmp_flag_32 *flag, int final_spin
-#if USE_ITT_BUILD
-                   , void * itt_sync_obj
-#endif
-                   );
-extern void __kmp_release_32(kmp_flag_32 *flag);
 extern void __kmp_wait_64(kmp_info_t *this_thr, kmp_flag_64 *flag, int final_spin
 #if USE_ITT_BUILD
                    , void * itt_sync_obj
 #endif
                    );
 extern void __kmp_release_64(kmp_flag_64 *flag);
-extern void __kmp_wait_oncore(kmp_info_t *this_thr, kmp_flag_oncore *flag, int final_spin
-#if USE_ITT_BUILD
-                   , void * itt_sync_obj
-#endif
-                   );
-extern void __kmp_release_oncore(kmp_flag_oncore *flag);
 
 extern void __kmp_infinite_loop( void );
 
 extern void __kmp_cleanup( void );
 
 #if KMP_HANDLE_SIGNALS
     extern int  __kmp_handle_signals;
     extern void __kmp_install_signals( int parallel_init );

runtime/src/kmp_wait_release.cpp

 /*
  * kmp_wait_release.cpp -- Wait/Release implementation
  */
 
 
 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.txt for details.
 //
 //===----------------------------------------------------------------------===//
 
 #include "kmp_wait_release.h"
 
-void __kmp_wait_32(kmp_info_t *this_thr, kmp_flag_32 *flag, int final_spin
-                   USE_ITT_BUILD_ARG(void * itt_sync_obj) )
-{
-    __kmp_wait_template(this_thr, flag, final_spin
-                        USE_ITT_BUILD_ARG(itt_sync_obj) );
-}
-
 void __kmp_wait_64(kmp_info_t *this_thr, kmp_flag_64 *flag, int final_spin
                    USE_ITT_BUILD_ARG(void * itt_sync_obj) )
 {
     __kmp_wait_template(this_thr, flag, final_spin
                         USE_ITT_BUILD_ARG(itt_sync_obj) );
 }
 
-void __kmp_wait_oncore(kmp_info_t *this_thr, kmp_flag_oncore *flag, int final_spin
-                       USE_ITT_BUILD_ARG(void * itt_sync_obj) )
-{
-    __kmp_wait_template(this_thr, flag, final_spin
-                        USE_ITT_BUILD_ARG(itt_sync_obj) );
-}
-
-
-
-void __kmp_release_32(kmp_flag_32 *flag) {
-    __kmp_release_template(flag);
-}
-
 void __kmp_release_64(kmp_flag_64 *flag) {
     __kmp_release_template(flag);
 }
-
-void __kmp_release_oncore(kmp_flag_oncore *flag) {
-    __kmp_release_template(flag);
-}