This is an archive of the discontinued LLVM Phabricator instance.

clang-rename: implement handling of remaining named casts
ClosedPublic

Authored by vmiklos on Jun 12 2016, 1:29 PM.

Diff Detail

Event Timeline

vmiklos updated this revision to Diff 60479.Jun 12 2016, 1:29 PM
vmiklos retitled this revision from to clang-rename: implement handling of remaining named casts.
vmiklos updated this object.
vmiklos added a reviewer: klimek.
vmiklos added a subscriber: cfe-commits.
klimek accepted this revision.Jun 12 2016, 11:37 PM
klimek edited edge metadata.

LG, although I believe the recent history of changes indicates that the approach is suboptimal, and we should address this on a higher level. But for now fixing the bugs seems like the right short-term approach.

This revision is now accepted and ready to land.Jun 12 2016, 11:37 PM

Yes, if there will be a way to avoid hooking into each and every AST callback, that sounds more effective. :-) I'm aware of one more bug around destructors when renaming a class, but then I'm (as a user) quite happy about the current state.

This revision was automatically updated to reflect the committed changes.