This is an archive of the discontinued LLVM Phabricator instance.

[include-fixer] give users an option to show N more headers in case there are too many candidates.
ClosedPublic

Authored by ioeric on Jun 9 2016, 7:06 AM.

Diff Detail

Event Timeline

ioeric updated this revision to Diff 60167.Jun 9 2016, 7:06 AM
ioeric retitled this revision from to [include-fixer] give users an option to show N more headers in case there are too many candidates..
ioeric updated this object.
ioeric added a reviewer: bkramer.
ioeric added a subscriber: cfe-commits.
bkramer edited edge metadata.Jun 10 2016, 3:26 AM

I'm not convinced that this use case is common enough to make the interface more complex. Should we remove (a) in favor of this?

ioeric updated this revision to Diff 60338.Jun 10 2016, 4:43 AM
ioeric edited edge metadata.
  • remove option (a) in favor of option (m); show a new prompt on invalid option instead of aborting.
bkramer accepted this revision.Jun 10 2016, 5:10 AM
bkramer edited edge metadata.
This revision is now accepted and ready to land.Jun 10 2016, 5:10 AM
This revision was automatically updated to reflect the committed changes.