This is an archive of the discontinued LLVM Phabricator instance.

[mips][dsp] Fix use without def on DSPCtrl registers read by rddsp intrinsic.
ClosedPublic

Authored by dsanders on Jun 7 2016, 3:39 AM.

Reviewers

Commits

dsanders retitled this revision from to [mips][dsp] Fix use without def on DSPCtrl registers read by rddsp intrinsic..

dsanders updated this object.

dsanders added a reviewer: sdardis.

dsanders added a subscriber: llvm-commits.

LGTM.

This revision is now accepted and ready to land.Jun 8 2016, 6:26 AM

Path

Size

lib/

Target/

Mips/

3 lines

test/

CodeGen/

Mips/

3 lines

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Lines	if (Subtarget->inMips16Mode())
return false;		return false;
return MipsDAGToDAGISel::runOnMachineFunction(MF);		return MipsDAGToDAGISel::runOnMachineFunction(MF);
}		}

void MipsSEDAGToDAGISel::addDSPCtrlRegOperands(bool IsDef, MachineInstr &MI,		void MipsSEDAGToDAGISel::addDSPCtrlRegOperands(bool IsDef, MachineInstr &MI,
MachineFunction &MF) {		MachineFunction &MF) {
MachineInstrBuilder MIB(MF, &MI);		MachineInstrBuilder MIB(MF, &MI);
unsigned Mask = MI.getOperand(1).getImm();		unsigned Mask = MI.getOperand(1).getImm();
unsigned Flag = IsDef ? RegState::ImplicitDefine : RegState::Implicit;		unsigned Flag =
		IsDef ? RegState::ImplicitDefine : RegState::Implicit \| RegState::Undef;

if (Mask & 1)		if (Mask & 1)
MIB.addReg(Mips::DSPPos, Flag);		MIB.addReg(Mips::DSPPos, Flag);

if (Mask & 2)		if (Mask & 2)
MIB.addReg(Mips::DSPSCount, Flag);		MIB.addReg(Mips::DSPSCount, Flag);

if (Mask & 4)		if (Mask & 4)
▲ Show 20 Lines • Show All 967 Lines • Show Last 20 Lines

	; RUN: llc -march=mipsel -mcpu=mips32 -mattr=+dsp < %s \| FileCheck %s			; RUN: llc -march=mipsel -mcpu=mips32 -mattr=+dsp -verify-machineinstrs < %s \| \
				; RUN: FileCheck %s

	define i32 @test__builtin_mips_extr_w1(i32 %i0, i32, i64 %a0) nounwind {			define i32 @test__builtin_mips_extr_w1(i32 %i0, i32, i64 %a0) nounwind {
	entry:			entry:
	; CHECK: extr.w			; CHECK: extr.w

	%1 = tail call i32 @llvm.mips.extr.w(i64 %a0, i32 15)			%1 = tail call i32 @llvm.mips.extr.w(i64 %a0, i32 15)
	ret i32 %1			ret i32 %1
	}			}
	▲ Show 20 Lines • Show All 1,227 Lines • Show Last 20 Lines