[clang-tidy] Ignore the deleted function in misc-definitions-in-headers.

[alexfh]

LG with one comment.

test/clang-tidy/misc-definitions-in-headers-cxx11.hpp

6 ↗

(On Diff #59841)

Just add this to the existing test file, the testing script uses -std=c++11 by default.

[hokein]

Use the existing test file.

clang-tidy/misc/DefinitionsInHeadersCheck.cpp

void DefinitionsInHeadersCheck::storeOptions(
     ClangTidyOptions::OptionMap &Opts) {
   Options.store(Opts, "UseHeaderFileExtension", UseHeaderFileExtension);
   Options.store(Opts, "HeaderFileExtensions", RawStringHeaderFileExtensions);
 }
 
 void DefinitionsInHeadersCheck::registerMatchers(MatchFinder *Finder) {
   if (!getLangOpts().CPlusPlus)
     return;
+  auto DefinitionMatcher =
+      anyOf(functionDecl(isDefinition(), unless(isDeleted())),
+            varDecl(isDefinition()));
   if (UseHeaderFileExtension) {
-    Finder->addMatcher(
-        namedDecl(anyOf(functionDecl(isDefinition()), varDecl(isDefinition())),
+    Finder->addMatcher(namedDecl(DefinitionMatcher,
                                  usesHeaderFileExtension(HeaderFileExtensions))
                            .bind("name-decl"),
                        this);
   } else {
     Finder->addMatcher(
-        namedDecl(anyOf(functionDecl(isDefinition()), varDecl(isDefinition())),
+        namedDecl(DefinitionMatcher,
                   anyOf(usesHeaderFileExtension(HeaderFileExtensions),
                         unless(isExpansionInMainFile())))
             .bind("name-decl"),
         this);
   }
 }
 
 void DefinitionsInHeadersCheck::check(const MatchFinder::MatchResult &Result) {

test/clang-tidy/misc-definitions-in-headers.hpp

 
 int f5(); // OK: function declaration.
 inline int f6() { return 1; } // OK: inline function definition.
 namespace {
   int f7() { return 1; }
 // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: function 'f7' defined in a header file;
 }
 
+int f8() = delete; // OK: the function being marked delete is not callable.
+
 int a = 1;
 // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: variable 'a' defined in a header file; variable definitions in header files can lead to ODR violations [misc-definitions-in-headers]
 CA a1;
 // CHECK-MESSAGES: :[[@LINE-1]]:4: warning: variable 'a1' defined in a header file;
 
 namespace NB {
   int b = 1;
 // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: variable 'b' defined in a header file;