Page MenuHomePhabricator

[cpu-detection] Naming convention.
AbandonedPublic

Authored by asbirlea on Jun 2 2016, 4:08 PM.

Details

Summary

Follow-up to D20926 (committed as r271595, r271596).
This patch is in preparation for a substantial refactoring of the code.

No functionality changed.

Diff Detail

Event Timeline

asbirlea updated this revision to Diff 59473.Jun 2 2016, 4:08 PM
asbirlea retitled this revision from to [cpu-detection] Naming convention.
asbirlea updated this object.
asbirlea updated this revision to Diff 59475.Jun 2 2016, 4:11 PM
  • Update comment after clang format
asbirlea retitled this revision from [cpu-detection] Naming convention to [cpu-detection] Naming convention..Jun 2 2016, 4:13 PM
echristo edited edge metadata.Jun 2 2016, 6:57 PM

Can you abandon this revision and start again while remembering to add
llvm-commits as you create the review please? Makes it much easier to make
sure everyone sees the mails.

Thanks!

llvm-commits edited edge metadata.Jun 2 2016, 7:04 PM

To elaborate a bit here: what's happening is that the update the list sees
is that you added the list and some reviewers, rather than an initial email
that contains the patch and your description of it so that people can scan
and look at patches without needing to go to phabricator.

asbirlea abandoned this revision.Jul 26 2016, 12:01 PM