This is an archive of the discontinued LLVM Phabricator instance.

Differential D20766

[clang-tidy] Fix script adding new clang-tidy check
ClosedPublic

Authored by etienneb on May 27 2016, 8:19 PM.

Details

Reviewers
alexfh
Commits
rG1c51a2d1d487: [clang-tidy] Fix script adding new clang-tidy check
rCTE271207: [clang-tidy] Fix script adding new clang-tidy check
rL271207: [clang-tidy] Fix script adding new clang-tidy check
Summary

The getName() call is useless. It's better to show a better example
as tutorial.

Diff Detail

Event Timeline

etienneb updated this revision to Diff 58878.May 27 2016, 8:19 PM
etienneb retitled this revision from to [clang-tidy] Fix script adding new clang-tidy check.
etienneb updated this object.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
alexfh accepted this revision.May 27 2016, 11:42 PM
alexfh edited edge metadata.

LG

This revision is now accepted and ready to land.May 27 2016, 11:42 PM
Closed by commit rL271207: [clang-tidy] Fix script adding new clang-tidy check (authored by etienneb). · Explain WhyMay 30 2016, 8:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang-tidy/
2 lines

Diff 58878

clang-tidy/add_new_check.py

Show First 20 Lines • Show All 132 Lines • ▼ Show 20 Lines
} }
void %(check_name)s::check(const MatchFinder::MatchResult &Result) { void %(check_name)s::check(const MatchFinder::MatchResult &Result) {
// FIXME: Add callback implementation. // FIXME: Add callback implementation.
const auto *MatchedDecl = Result.Nodes.getNodeAs<FunctionDecl>("x"); const auto *MatchedDecl = Result.Nodes.getNodeAs<FunctionDecl>("x");
if (MatchedDecl->getName().startswith("awesome_")) if (MatchedDecl->getName().startswith("awesome_"))
return; return;
diag(MatchedDecl->getLocation(), "function '%%0' is insufficiently awesome") diag(MatchedDecl->getLocation(), "function '%%0' is insufficiently awesome")
<< MatchedDecl->getName() << MatchedDecl
<< FixItHint::CreateInsertion(MatchedDecl->getLocation(), "awesome_"); << FixItHint::CreateInsertion(MatchedDecl->getLocation(), "awesome_");
} }
} // namespace %(module)s } // namespace %(module)s
} // namespace tidy } // namespace tidy
} // namespace clang } // namespace clang
""" % {'check_name': check_name_camel, """ % {'check_name': check_name_camel,
'module': module}) 'module': module})
▲ Show 20 Lines • Show All 156 Lines • Show Last 20 Lines