Page MenuHomePhabricator

Disable lifetime-start-on-first-use analysis.

Authored by thanm on May 27 2016, 8:11 AM.



Turn off lifetime-start-on-first-use enhancement for the moment
pending a fix for bug 27903.

Bug: 27903

Diff Detail

Event Timeline

thanm updated this revision to Diff 58788.May 27 2016, 8:11 AM
thanm retitled this revision from to Disable lifetime-start-on-first-use analysis..
thanm updated this object.
thanm added reviewers: tejohnson, wmi, qcolombet, gbiv.
thanm added a subscriber: llvm-commits.
tejohnson accepted this revision.May 27 2016, 8:20 AM
tejohnson edited edge metadata.

Couple of minor comments, otherwise LGTM. Thanks!


LLVM tends to use "PR27903" when referring to bug ids. Also "FIXME" instead of "NB"


If this test case is exposing the bug, probably a FIXME with the expected output once this is corrected would be good.

This revision is now accepted and ready to land.May 27 2016, 8:20 AM
thanm marked an inline comment as done.May 27 2016, 8:31 AM

Thanks. Fixed the issues you cited, will post a revised patch.


Yes. this test case is exposing the bug. I will try to make the comment clearer.

thanm updated this revision to Diff 58791.May 27 2016, 8:31 AM
thanm edited edge metadata.

Incorporate code review suggestions by Teresa.

This revision was automatically updated to reflect the committed changes.