This is an archive of the discontinued LLVM Phabricator instance.

[cmake] Remove the LLDB versions of the exception-controlling variables
ClosedPublic

Authored by labath on May 26 2016, 3:35 AM.

Details

Summary

One can still use the LLVM variables to control this: LLVM_ENABLE_EH, LLVM_ENABLE_RTTI. It's not
clear to me why one would want to control these at lldb level and it's generally not even a good
idea to compile parts of the same binary with different values of these flags.

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 58587.May 26 2016, 3:35 AM
labath retitled this revision from to [cmake] Remove the LLDB versions of the exception-controlling variables.
labath updated this object.
labath added reviewers: zturner, tfiala.
labath added a subscriber: lldb-commits.

Zachary, Todd, you added these in D3929. I know it's a long time, but do you recall what was the original motivation for that?

In light of the issue in D20671, I've experimenting with compiling lldb with exceptions enabled, and this code here is interfering with the standard llvm logic for enabling them (LLVM_ENABLE_EH). Enabling this should not make any difference in the common case, as llvm already adds one set of exception-disabling flags if you don't specify the flag I mentioned (llvm/cmake/modules/AddLLVM.cmake).

So, unless we know of a concrete use case where this is needed, I think we should remove it.

tfiala edited edge metadata.May 26 2016, 8:51 AM

Having a look now. I don't recall the context yet.

Enabling this should not make any difference in the common case, as llvm already adds one set of exception-disabling flags if you don't specify the flag I mentioned (llvm/cmake/modules/AddLLVM.cmake).

(And by "Enabling" I mean "Removing" :P )

tfiala accepted this revision.May 26 2016, 8:58 AM
tfiala edited edge metadata.

This looks fine to me. ( D20671 also looked fine, looks like I missed looking at that yesterday).

Since Zachary initially wanted this on Windows, I suspect he needs to verify that he can still achieve the same result.

This revision is now accepted and ready to land.May 26 2016, 8:58 AM

Enabling this should not make any difference in the common case, as llvm already adds one set of exception-disabling flags if you don't specify the flag I mentioned (llvm/cmake/modules/AddLLVM.cmake).

(And by "Enabling" I mean "Removing" :P )

;-)

zturner edited edge metadata.May 26 2016, 8:59 AM
zturner added a subscriber: zturner.

Don't think this is needed anymore, lgtm

This revision was automatically updated to reflect the committed changes.