Skip to content

Commit a0adeb6

Browse files
committedMay 26, 2016
[cmake] Remove the LLDB versions of the exception-controlling variables
Summary: One can still use the LLVM variables to control this: LLVM_ENABLE_EH, LLVM_ENABLE_RTTI. It's not clear to me why one would want to control these at lldb level and it's generally not even a good idea to compile parts of the same binary with different values of these flags. Reviewers: zturner, tfiala Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D20673 llvm-svn: 270863
1 parent 555cf5e commit a0adeb6

File tree

1 file changed

+0
-22
lines changed

1 file changed

+0
-22
lines changed
 

‎lldb/cmake/modules/LLDBConfig.cmake

-22
Original file line numberDiff line numberDiff line change
@@ -338,28 +338,6 @@ if (HAVE_LIBDL)
338338
list(APPEND system_libs ${CMAKE_DL_LIBS})
339339
endif()
340340

341-
if(LLDB_REQUIRES_EH)
342-
set(LLDB_REQUIRES_RTTI ON)
343-
else()
344-
if(LLVM_COMPILER_IS_GCC_COMPATIBLE)
345-
set(LLDB_COMPILE_FLAGS "${LLDB_COMPILE_FLAGS} -fno-exceptions")
346-
elseif(MSVC)
347-
add_definitions( -D_HAS_EXCEPTIONS=0 )
348-
set(LLDB_COMPILE_FLAGS "${LLDB_COMPILE_FLAGS} /EHs-c-")
349-
endif()
350-
endif()
351-
352-
# Disable RTTI by default
353-
if(NOT LLDB_REQUIRES_RTTI)
354-
if (LLVM_COMPILER_IS_GCC_COMPATIBLE)
355-
set(LLDB_COMPILE_FLAGS "${LLDB_COMPILE_FLAGS} -fno-rtti")
356-
elseif(MSVC)
357-
set(LLDB_COMPILE_FLAGS "${LLDB_COMPILE_FLAGS} /GR-")
358-
endif()
359-
endif()
360-
361-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${LLDB_COMPILE_FLAGS}")
362-
363341
if (CMAKE_SYSTEM_NAME MATCHES "Linux")
364342
# Check for syscall used by lldb-server on linux.
365343
# If these are not found, it will fall back to ptrace (slow) for memory reads.

0 commit comments

Comments
 (0)
Please sign in to comment.