Page MenuHomePhabricator

[BPF] Remove exit-on-error flag in test (PR27767)
ClosedPublic

Authored by rovka on May 24 2016, 9:35 AM.

Details

Summary

The exit-on-error flag is needed to avoid an assert where llvm::SelectionDAGISel::LowerArguments doesn't create enough arguments. Fill up with zeroes to reach the right number of args.

Fixes PR27767.

Diff Detail

Repository
rL LLVM

Event Timeline

rovka updated this revision to Diff 58249.May 24 2016, 9:35 AM
rovka retitled this revision from to [BPF] Remove exit-on-error flag in test (PR27767).
rovka updated this object.
rovka added a reviewer: ast.
rovka added subscribers: llvm-commits, rengolin.
ast requested changes to this revision.May 24 2016, 11:06 AM
ast edited edge metadata.
ast added inline comments.
lib/Target/BPF/BPFISelLowering.cpp
202 ↗(On Diff #58249)

bpf backend doesn't like 'undef' since most likely it would mean that generated code will be reject by the kernel verifier with hard to decipher error. Can you change it to use const zero instead? In general continuing after "too many args" is hard. At least with zero there is a chance that generated code is somewhat sane.

This revision now requires changes to proceed.May 24 2016, 11:06 AM
rovka updated this revision to Diff 58402.May 25 2016, 4:40 AM
rovka updated this object.
rovka edited edge metadata.

Updated to use zeroes instead of undef.

rovka marked an inline comment as done.May 25 2016, 9:22 AM
ast accepted this revision.May 25 2016, 9:31 AM
ast edited edge metadata.

thanks!

This revision is now accepted and ready to land.May 25 2016, 9:31 AM
This revision was automatically updated to reflect the committed changes.