This is an archive of the discontinued LLVM Phabricator instance.

[MBP] Remove a redundant skipFunction(). NFC.
ClosedPublic

Authored by haicheng on May 18 2016, 11:22 AM.

Details

Summary

skipFunction() is called twice in runOnMachineFunction(). Remove one of them.

Diff Detail

Repository
rL LLVM

Event Timeline

haicheng updated this revision to Diff 57651.May 18 2016, 11:22 AM
haicheng retitled this revision from to [MBP] Remove a redundant skipFunction(). NFC..
haicheng updated this object.
haicheng added reviewers: mcrosier, gberry, mssimpso.
haicheng set the repository for this revision to rL LLVM.
mssimpso edited edge metadata.May 18 2016, 11:26 AM

LGTM, with a minor comment.

lib/CodeGen/MachineBlockPlacement.cpp
1458

My preference would be to remove the second check instead of the first. This would match the other passes.

haicheng updated this revision to Diff 57662.May 18 2016, 12:39 PM
haicheng edited edge metadata.
haicheng marked an inline comment as done.

Address Matt's comment. Thank you, Matt.

This revision is now accepted and ready to land.May 18 2016, 1:19 PM
This revision was automatically updated to reflect the committed changes.