This is an archive of the discontinued LLVM Phabricator instance.

[LNT] Update timeit.sh to have the same return code as timeit when --append-exitstatus is used
ClosedPublic

Authored by sbaranga on May 18 2016, 5:13 AM.

Details

Summary

When passing --append-exitstatus, timeit will write the exit status
to the output and return 0 (with some exceptions in some edge cases).
The exit status will then be checked as part of the output with fpcmp.

We need timeit.sh to do the same (otherwise we will wrongly record a
failure for some tests).

Diff Detail

Event Timeline

sbaranga updated this revision to Diff 57595.May 18 2016, 5:13 AM
sbaranga retitled this revision from to [LNT] Update timeit.sh to have the same return code as timeit when --append-exitstatus is used.
sbaranga updated this object.
sbaranga added a reviewer: jmolloy.
sbaranga added a subscriber: llvm-commits.
jmolloy accepted this revision.May 18 2016, 5:19 AM
jmolloy edited edge metadata.

LGTM!

This revision is now accepted and ready to land.May 18 2016, 5:19 AM
sbaranga closed this revision.May 18 2016, 5:37 AM

Thanks, r269912.

-Silviu