Use full path to clang.exe in LLDB_TEST_COMPILER

[zturner]

Summary

I basically just copied your code, so this should be correct, but just want to make sure I'm not missing anything.

[gkistanova]

Looks fine.
The only possible issue is the special symbols termination in paths. You may want to add quotation marks around paths or something.

[gkistanova]

Almost missed that. Sorry.

It seems you are taking a fully qualified path to a wrong directory.
Shouldn't it be for build_dir and not "."?

zorg/buildbot/builders/LLDBBuilder.py

94

Unless I'm missing something, it should be workdir=build_dir here.

zorg/buildbot/builders/LLDBBuilder.py

def getLLDBWindowsCMakeBuildFactory(
     if jobs:
         build_cmd.append(WithProperties("-j%s" % jobs))
         install_cmd.append(WithProperties("-j%s" % jobs))
         test_cmd.append(WithProperties("-j%s" % jobs))
 
     # Global configurations
     build_dir='build'
 
+    # get full path to build directory
+    f.addStep(SetProperty(name="get_builddir",
+                          command=["pwd"],
+                          property="builddir",
+                          description="set build dir",
+                          workdir="."))
+    
     ############# CLEANING
     cleanBuildRequested = lambda step: step.build.getProperty("clean") or clean
     f.addStep(RemoveDirectory(name='clean '+build_dir,
                 dir=build_dir,
                 haltOnFailure=False,
                 flunkOnFailure=False,
                 doStepIf=cleanBuildRequested
                 ))
 
     # Use batch files instead of ShellCommand directly, Windows quoting is
     # borked. FIXME: See buildbot ticket #595 and buildbot ticket #377.
-    clang_exe = 'bin/clang.exe'    # ./bin/clang.exe
+    clang_exe = WithProperties('%(builddir)s/bin/clang.exe')
+    
     f.addStep(batch_file_download.BatchFileDownload(name='cmakegen',
                                 command=[cmake, "-G", "Ninja", "../llvm",
                                          "-DCMAKE_BUILD_TYPE="+config,
                                          '-DPYTHON_HOME=' + python_source_dir,
                                          "-DCMAKE_INSTALL_PREFIX=../install",
                                          "-DLLDB_TEST_COMPILER=" + clang_exe]
                                          + extra_cmake_args,
                                 workdir=build_dir))