This is an archive of the discontinued LLVM Phabricator instance.

[include-fixer] Use scope contexts information to improve query.
ClosedPublic

Authored by hokein on May 12 2016, 7:31 AM.

Diff Detail

Event Timeline

hokein updated this revision to Diff 57038.May 12 2016, 7:31 AM
hokein retitled this revision from to [include-fixer] Use scope contexts information to improve query..
hokein updated this object.
hokein set the repository for this revision to rL LLVM.
hokein added a subscriber: cfe-commits.
bkramer requested changes to this revision.May 12 2016, 8:59 AM
bkramer edited edge metadata.

This needs more tests (check that using stuff from a different namespace in namespace scope still works). It's also better written as a unit test against the in-memory database, that way we don't have to create a file for every test.

This revision now requires changes to proceed.May 12 2016, 8:59 AM
hokein updated this revision to Diff 57142.May 13 2016, 2:14 AM
hokein edited edge metadata.

Improvement and use unittest.

bkramer accepted this revision.May 13 2016, 5:03 AM
bkramer edited edge metadata.

Tests look much better now, thanks!

This revision is now accepted and ready to land.May 13 2016, 5:03 AM
hokein updated this revision to Diff 57197.May 13 2016, 8:41 AM
hokein edited edge metadata.

Rebase.

This revision was automatically updated to reflect the committed changes.