Page MenuHomePhabricator

[ELF] - Make few members of Writer to be global and export them for reuse
ClosedPublic

Authored by grimar on May 10 2016, 8:26 AM.

Details

Summary

Creating sections on linkerscript side requires some methods
that can be reused if are exported from writer.
D19976 already uses these three.

In combination with D19977 and D19981, this one can help
to remove the noise from D19976 patch.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar updated this revision to Diff 56720.May 10 2016, 8:26 AM
grimar retitled this revision from to [ELF] - Make few members of Writer to be global and export them for reuse.
grimar updated this object.
grimar added reviewers: ruiu, rafael.
grimar added subscribers: grimar, llvm-commits.
emaste added a subscriber: emaste.May 10 2016, 10:20 AM
grimar updated this revision to Diff 63518.Jul 11 2016, 8:12 AM
  • Rebased
  • Moved isDiscarded() definition to InputSections.h
ruiu accepted this revision.Jul 11 2016, 1:54 PM
ruiu edited edge metadata.

LGTM

ELF/Writer.cpp
124 ↗(On Diff #63518)

While you are here, please remove llvm::.

This revision is now accepted and ready to land.Jul 11 2016, 1:54 PM
This revision was automatically updated to reflect the committed changes.